Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export gist to personal GitHub account #239

Open
pathmapper opened this issue Feb 2, 2018 · 2 comments
Open

Export gist to personal GitHub account #239

pathmapper opened this issue Feb 2, 2018 · 2 comments

Comments

@pathmapper
Copy link
Contributor

Currently the export to Gist is creating an anonymous gist.

If a user is logged into GitHub, the gist would be created in the GitHub account.

Maybe the Login with GitHub functionality can be taken from #155 (comment) ?

Benefits:

  • Directly creating a gist in the own GitHub account. Currently you have to fork the anonymous gist to do so.
  • Ability to delete gists not needed/wanted anymore from the web browser. Currently you have to contact the GitHub support to delete an anonymous gist.
@orangemug
Copy link
Collaborator

I like the idea, probably on hold until I finish the GitHub integration in issue #155.

One thing we can do now is mock up a UI. The way I see it the export modal would need to account for

  • anonymous (public/private)
  • user (public/private)

It'd also be nice to tidy up the export modal in general. For example at the moment we also ask for mapbox/openmaptiles keys on export. If you're using the fallback keys, see #230 (comment), I don't think it's obvious why you're being asked for these keys.

I think a redesign of that modal would be worth considering as a part of this issue.

@pathmapper
Copy link
Contributor Author

anonymous (public/private)

Not needed anymore in the future, see #269.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants