Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps #117

Open
marcoaaguiar opened this issue Dec 2, 2024 · 6 comments
Open

Next steps #117

marcoaaguiar opened this issue Dec 2, 2024 · 6 comments

Comments

@marcoaaguiar
Copy link
Owner

Making this issue to ask for ideas on how to improve the tool, also for the Contributors is there suggestions regarding the codebase?

@marcoaaguiar
Copy link
Owner Author

Bonus question: do you think we should open a Discord to make it easier to talk to each other?

@meatwallace
Copy link
Contributor

i'll keep contributing nodes where i find them but imo the tool is fairly feature complete and already achieves what i assume is it's purpose: useful hype/cope tool for pre-release :D

as an extension of the work in #97, its probably worth adding a simple 'share link' button that grabs the URL on the clipboard. outside of that, feels like it nails pretty much everything as is and sits perfectly along https://poe2skills.com/ etc

there's a bunch that could be done on the code qual/organisation front but unless you see this as larger as just a pre-release thing id weigh the effort.

@neo-daru
Copy link
Contributor

neo-daru commented Dec 3, 2024

Agree 100% with @meatwallace. Once early access is launched and the game gets datamined, then the community contribution for nodes will no longer be needed.

Also I'm sure many of us will be busy playing the game after that!

@Giusti
Copy link
Contributor

Giusti commented Dec 3, 2024

Hey guys, I have a few smaller QoL features in mind which I guess could be done until EA

  • Make the collapsible sidebar feature also available on Desktop (currently only visible on Tablet)
  • Give selected nodes a border ring to make them more visible
  • Maybe find an easy solution to render / highlight connecting paths between selected nodes
  • Generate a shareable link with selected nodes & ascendancy (seems this works already :D)
  • If the sharing works, we could have a name field for builds and list them in the sidebar (storing in localstorage?)
  • Stat overview (right sidebar?) listing keystones, ascendancies & aggregating stats together
  • Split the nodes file Into keystones, notables, smalls, ascendancies to avoid merge conflict inconveniance

But yea, I agree that most of us will be playing from Friday on and I think the necessary functionalities are there

@lfmnovaes
Copy link
Contributor

lfmnovaes commented Dec 3, 2024

I can see some things still being done for QoL purposes because they are somewhat easy to do. Like what Giusti mentioned:

  • A way to store multiple builds in one place and be able to navigate between them
  • Stat overview with the merged similar stats all in one place

And:

  • Make all nodes clickable/interactable (we are missing some, especially from ascendancies)
  • Improve styling, contrast, and visuals from interactions with nodes in the tree
  • Make the results from the search clickable, and by clicking it centralizes the camera on the node

These would improve the tool a lot and would help the community after the launch. But after that, PoB and poeplanner will take over and probably we won't have a reason for this project to go further.

@PhillDubois
Copy link

Hello, I think it's a nice idea to open a Discord. I think it would also be nice to have a different repository for the collected data, I was thinking about creating one with the passive nodes and also gems, items, etc.. What do you think about that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants