From 1776191127d82eb363fe04069d039199a92efb0e Mon Sep 17 00:00:00 2001 From: Myles Scolnick Date: Tue, 29 Oct 2024 09:50:55 -0700 Subject: [PATCH] fix: bump narwhals to 1.12.0 (#2742) --- pyproject.toml | 4 ++-- tests/_plugins/ui/_impl/tables/test_pandas_table.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 58684ec5821..6913b056a42 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -42,7 +42,7 @@ dependencies = [ # required dependency in Starlette for SessionMiddleware support "itsdangerous>=2.0.0", # for dataframe support - "narwhals>=1.9.0", + "narwhals>=1.12.0", # for cell formatting; if user version is not compatible, no-op # so no lower bound needed "ruff", @@ -147,7 +147,7 @@ dependencies = [ # Types for mypy "panel~=1.5.3", "polars~=1.9.0", - "narwhals>=1.9.0", + "narwhals>=1.12.0", "matplotlib>=3.8.0", "pyarrow-stubs>=17.0", "pandas-stubs>=1.5.3.230321", diff --git a/tests/_plugins/ui/_impl/tables/test_pandas_table.py b/tests/_plugins/ui/_impl/tables/test_pandas_table.py index 985c85463ff..fa14129fa34 100644 --- a/tests/_plugins/ui/_impl/tables/test_pandas_table.py +++ b/tests/_plugins/ui/_impl/tables/test_pandas_table.py @@ -738,7 +738,7 @@ def test_dataframe_with_all_null_column(self) -> None: summary = manager.get_summary("B") assert summary.nulls == 3 assert summary.total == 3 - assert summary.unique == 1 + assert summary.unique is None def test_dataframe_with_mixed_types(self) -> None: df = pd.DataFrame({"A": [1, "two", 3.0, True]})