Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devcontainer.json needs updated to remove runArgs #28

Open
mathemaphysics opened this issue May 26, 2022 · 1 comment
Open

Devcontainer.json needs updated to remove runArgs #28

mathemaphysics opened this issue May 26, 2022 · 1 comment
Assignees
@mathemaphysics

Comments

@mathemaphysics
Copy link
Owner

We no longer want to use network=agent because it will require that it already exist. This is currently not a docker-compose project so it won't generate its own network and volumes if they don't already exist. This may be better suited to this style for testing purposes.
@mathemaphysics mathemaphysics self-assigned this May 26, 2022
@mathemaphysics
Copy link
Owner Author

What freaking nightmare converting devcontainer.json over to boot up using a docker-compose.yml which starts an AMQP broker to use for unit testing. This shouldn't have been so horrible. Docker compose v1 was installed in place of what I thought was v2. This cost me hours of my life I'll never get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathemaphysics mathemaphysics

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

28-devcontainerjson-needs-updated-to-remove-runargs mathemaphysics/agent
1 participant
@mathemaphysics