Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LookupWellKnown doesn't specify user agent #253

Open
phol opened this issue Jan 13, 2021 · 3 comments
Open

LookupWellKnown doesn't specify user agent #253

phol opened this issue Jan 13, 2021 · 3 comments
Labels
T-Task

Comments

@phol
Copy link

phol commented Jan 13, 2021

Background information

  • Dendrite version or git SHA: v0.3.5
  • Monolith or Polylith?: Monolith
  • SQLite3 or Postgres?: postgres
  • Running in Docker?: no
  • go version: go1.15.2 linux/amd64

Description

Right now, Dendrite identifies itself with the User-Agent string Go-http-client/2.0. This should be something like Dendrite/0.3.5, just as Synapse does.

Steps to reproduce

  • Tail your web server access logs for /.well-known/matrix/server
  • Dendrite identifies itself as Go-http-client/2.0
  • Synapse identifies itself as Synapse/1.24.0
@tulir
Copy link
Member

tulir commented Jan 13, 2021

Note that this only applies to .well-known requests, not federation requests in general.

@phol phol changed the title Dendrite uses standard Go-http-client/2.0 instead of e.g. Dendrite/0.3.5 as User-Agent in HTTP requests Dendrite uses standard Go-http-client/2.0 instead of e.g. Dendrite/0.3.5 as User-Agent in .well-known requests Jan 13, 2021
@kegsay
Copy link
Member

kegsay commented Jan 29, 2021

I was going to say, I thought we did as per https://github.com/matrix-org/dendrite/blob/v0.3.8/setup/base.go#L313

@neilalexander
Copy link
Contributor

Well-known requests are exempt from that because LookupWellKnown in gmsl doesn't use the Client or FederationClient from setup.

Moving this issue to the gmsl repo.

@neilalexander neilalexander transferred this issue from matrix-org/dendrite Feb 4, 2021
@neilalexander neilalexander changed the title Dendrite uses standard Go-http-client/2.0 instead of e.g. Dendrite/0.3.5 as User-Agent in .well-known requests LookupWellKnown doesn't specify user agent Feb 4, 2021
@kegsay kegsay added the T-Task label Dec 6, 2022
@S7evinK S7evinK mentioned this issue Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neilalexander @phol @tulir @kegsay