Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatted_body isn't escaped when sending from Slack -> Matrix #540

Open
Half-Shot opened this issue Nov 6, 2020 · 1 comment
Open

formatted_body isn't escaped when sending from Slack -> Matrix #540

Half-Shot opened this issue Nov 6, 2020 · 1 comment
Labels
substitutions An issue relating to translation of event content between Slack and Matrix. T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@Half-Shot
Copy link
Contributor

Leading to messages appearing broken:

{
  "content": {
    "body": "<3",
    "format": "org.matrix.custom.html",
    "formatted_body": "<3",
    "msgtype": "m.text"
  },
  "origin_server_ts": 1604687599444,
  "sender": "@slack_jobmachine_U049HHFSJ:jobmachine.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 378585
  },
  "event_id": "$h_9beldUfb-IgLnn3qK0a9inFsl36yELSondXWzdtHs",
  "room_id": "!jPyDpGsiZKKZULwFzz:jobmachine.org"
}

image
@Half-Shot Half-Shot added the bug label Nov 6, 2020
@Cadair Cadair added the substitutions An issue relating to translation of event content between Slack and Matrix. label Apr 7, 2021
@jaller94 jaller94 added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. and removed bug labels May 16, 2022
@tadzik
Copy link
Contributor

tadzik commented Apr 4, 2024 •
edited
Loading

I cannot reproduce it anymore, even on develop

EDIT: Actually, <3 seems to just work now thanks to Element – the event source is the same. It's fixed properly in #781 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
substitutions An issue relating to translation of event content between Slack and Matrix. T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tadzik @Cadair @Half-Shot @jaller94