Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify sample names #1

Open
mattravenhall opened this issue Sep 5, 2018 · 1 comment
Open

Allow users to specify sample names #1

mattravenhall opened this issue Sep 5, 2018 · 1 comment
Assignees
Labels
enhancement partially resolved For part, but not fully, resolved issues.

Comments

@mattravenhall
Copy link
Owner

Currently sample names are pulled from input vcf files by assuming they are given as full paths with only one full stop character. This works in most cases, but will fail if user vcf contain multiple full stops, or a user short-hands their path (ie. ./thisfile.vcf). This method also restricts users who with to redefine their sample names from non-file names.

To resolve this, I plan to allow for a special column in the subPops file (ie. named 'SampleID') which will link file locations to custom IDs.

@mattravenhall
Copy link
Owner Author

SV-Pop is now robust to additional 'full-stops' in paths, though it is advised to use full paths where possible.

@mattravenhall mattravenhall added the partially resolved For part, but not fully, resolved issues. label Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement partially resolved For part, but not fully, resolved issues.
Projects
None yet
Development

No branches or pull requests

1 participant