Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevents file comments for pull requests with a huge number of issues #96

Open
jizhilong opened this issue Feb 20, 2020 · 0 comments
Open

prevents file comments for pull requests with a huge number of issues #96

jizhilong opened this issue Feb 20, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jizhilong
Copy link
Contributor

with file comment enabled, the pr decoration gate will send several comments to gitlab/github/bitbucket. Which is really nice in most situation, but if someone accidentally pushed
a bunch of tool generated code to a merge request, the number of issues will be horrible, posting file comments in such a situation will not help.
@jizhilong jizhilong changed the title disable file comment if the number of issues in a pr excceed some value disable file comment if the count of issues in a pr excceed value Feb 21, 2020
@jizhilong jizhilong changed the title disable file comment if the count of issues in a pr excceed value prevents file comments for pull requests with a huge number of issues Feb 22, 2020
@mc1arke mc1arke added the enhancement New feature or request label Feb 22, 2020
@PiekJ PiekJ mentioned this issue Jul 20, 2020
Closed
PiekJ pushed a commit to PiekJ/sonarqube-community-branch-plugin that referenced this issue Aug 3, 2020
@PiekJ
Feature: mc1arke#135 / mc1arke#96 comments filter and limiter.
980e861 
implemented a filter system with 3 filters (maxamount,severy,type)
added commentfilter to the githubpullrequest decorator
fixed the tests I broke with adding the filter
added test to verify the filter is called for the Github Graphql
wrote test for IssueFilterRunner.
Added test for TypeExclusionFilter and SeverityExclusionFilter
Added tests for TypeComparator
Added tests for SeverityComparator
Added default comparators for IssueFilterRunner for real build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jizhilong @mc1arke