Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a mechanism for querying the input and output sizes of the model #12

Open
carterbox opened this issue Oct 17, 2022 · 2 comments
Open

Make a mechanism for querying the input and output sizes of the model #12

carterbox opened this issue Oct 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@carterbox
Copy link
Collaborator

Could you please provide a mechanism for querying the NN input and output sizes? (currently everything is 128x128, but it sounds like people want to move to 512x512). PtychoNN only supports square detectors at the moment, but it might be good to design the API with support for rectangular detectors.

This should probably be a parameter of the Tester/model classes.
@carterbox carterbox added the enhancement New feature or request label Oct 17, 2022
@carterbox
Copy link
Collaborator Author

It looks like the current implementation of ReconSmallPhaseModel is actually input shape agnostic? There is a minimum supported input size (16x16), but since the model is convolution based the model architecture is somewhat independent of the input/output data.

@carterbox
Copy link
Collaborator Author

We could include the name of the model and the training data size in the filename instead of just calling it best_model.pth. So something like SmallReconModel_32x32.pth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carterbox