-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superpoint + Tangent Images #7
Comments
So SIFT is actually is baked into the implementation of the the visibile keypoints function in my spherical distortion library. (This more of a result of tight timing before the CVPR deadline so it wasn't as extensible as I'd have liked.) A good work-around is to use the gnomonic (rectilinear) projection to map the corners of the face of the icosahedron onto the corresponding tangent image and just keep the keypoints that fall within that projected triangle. |
Take a look at this TangentUVToSpherical function in my PR to OpenMVG. This shows how to convert the coordinates from tangent image pixels back to equirectangular image pixels. Similarly, take a look here to see how to select only pixels (or features) that fall within the valid region of the tangent image. If I have some more time I will update this repo with that logic so any descriptor type can be used. |
@Artcs1 Okay this was something that was bugging me for a while, so I just pushed a fixe. Version 1.1 of my spherical-distortion repo now includes a function to convert tangent image coordinates to spherical coordinates. You can see an example of how you can use this for computing SIFT descriptors in It should be fairly clear how to adapt this to SuperPoint. For example, adjusting part of the
Let me know if this helps! |
Hi @meder411, First, I adapt the code of visible keypoints function, to operate with the size of the keypoint vector, these fix my first experiment (recover pose pipeline), now the SuperPoint+TangentImages performs well under rotation on Z axis, but in Y and X axis isn't. I will test with the new function in the library and report the results. Thank you for all! |
Hi @meder411,
First congrats for the excellent work, I am working with your library with the keypoint detector part I do a modification to the sift key points, to work with Superpoint but I notice when the code rendering the descriptors always return 128 dimension vector. Is there a way to change this number? In the Superpoint architecture, I have a 256 dimension vector, so I run twice the rendering with two different 128 dimension vector and then concatenating it. Does this procedure maybe affect the result? What do you think? I don't find many information in the paper for the rendering part. Is there any reference available?
Thank you @meder411
The text was updated successfully, but these errors were encountered: