-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: merger into the upstream #38
Comments
Hi @JounQin . Thanks for your contribution to prettier & eslint ecosystem! It would be nice for eslint-plugin-prettier to support those features natively. But I think this fork might not be an ideal implementation:
Based on your knowledgement about prettier, I believe that you can find a better way to support similar features. Let me know if I could help anything. |
Thanks, I do have some ideas as described above, I'm thinking what's the best choice or we may be able to support all choices. The benefit of |
Hi @meteorlxy !
I'm the current active maintainer of https://github.com/prettier/eslint-plugin-prettier, and just see this fork accidentally few days ago.
And I think about that is there any chance to merge this fork back into upstream? I believe that the custom blocks support is great for such frameworks commonly like Vue, Svelte, Astro, etc.
If you agree and want to raise a PR for upstream that'll be appreciated. Otherwise I'll think about how to implement such features in
eslint-plugin-prettier
.I want us to collaborate together with @BPScott.
The text was updated successfully, but these errors were encountered: