Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timestep mandatory in get_contour() #109

Open
thorbjoernl opened this issue Jan 16, 2025 · 0 comments
Open

Make timestep mandatory in get_contour() #109

thorbjoernl opened this issue Jan 16, 2025 · 0 comments
Milestone

Comments

@thorbjoernl
Copy link
Collaborator

With the newly split contour files retrieval of all timesteps in a single requests (how get_contour worked before #106) will not work when reading the new (split) files. Re-adding this functionality for these files, would probably require low level path globing or adding a queryable index to determine which files to combine, which seems like more effort than it's worth. Instead we should make timestep mandatory.

Since this is a breaking change, this should be done as part of v0.3.0

@thorbjoernl thorbjoernl added this to the m2025-02 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant