Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit check_up_to_date for nmboot models #702

Open
barrettk opened this issue Jun 18, 2024 · 1 comment
Open

Revisit check_up_to_date for nmboot models #702

barrettk opened this issue Jun 18, 2024 · 1 comment
Labels
bootstrap Bootstrap development

Comments

@barrettk
Copy link
Collaborator

A check_up_to_date was recently implemented in #687 (see method). There are couple implementation details we are considering changing:

  • This call aborts if the model has not been submitted. Due to the unique nature of bootstrap runs, this is not actually necessary. In other words you could check if the model was up-to-date before submitting the model if we removed this abort call. This is because we hash the based_on_data and model during the setup phase, rather than the submission. We are considering removing this abort call
  • Add a check_up_to_date call in submit_model.bbi_nmboot_model
@barrettk barrettk added the bootstrap Bootstrap development label Jun 18, 2024
@barrettk
Copy link
Collaborator Author

FWIW this is not an issue that needs to be addressed before we release the new bootstrap feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap Bootstrap development
Projects
None yet
Development

No branches or pull requests

1 participant