Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nm_join() and nm_data() to optionally not return integer #721

Open
kylebaron opened this issue Oct 1, 2024 · 3 comments
Open

Change nm_join() and nm_data() to optionally not return integer #721

kylebaron opened this issue Oct 1, 2024 · 3 comments

Comments

@kylebaron
Copy link
Contributor

kylebaron commented Oct 1, 2024

Needs discussion; but I think it might simplify things downstream. To clarify, R & data.table do it slightly different than readr; if we did this change, we'd just be moving toward making the output more like what readr returns.

Also, I'm going to do everything I can with the downstream stuff to handle this well; I think I can do that and don't want to make this just about our downstream tooling.

@seth127
Copy link
Collaborator

seth127 commented Oct 1, 2024

Thanks Kyle. Would making the change suggested in #722 accomplish this?

@kylebaron
Copy link
Contributor Author

@seth127 No; I think #722 only addresses long integers, not integer to numeric / double. Related but not the same so I made two issues.

@kylebaron
Copy link
Contributor Author

@seth127 one way this is related: if we ask data.table to return long integers as doubles, then it would make sense to return all ints as doubles out of consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants