Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Races? #2

Open
Ten0 opened this issue Aug 8, 2024 · 1 comment · May be fixed by #3
Open

Races? #2

Ten0 opened this issue Aug 8, 2024 · 1 comment · May be fixed by #3

Comments

@Ten0
Copy link

Ten0 commented Aug 8, 2024

First, thanks for sharing this.

I'm wondering what in the code guarantees that I'm not deleting a changeset before the related deployment from the aws CLI on a separate process manages to read the result of the creation of that changeset.

From reading the code, unless I'm mistaken, it seems that it may instantly delete any changeset that was just created, possibly not letting the time to whoever created it to collect its status first.

This means it may cause concurrent deployments to fail.

Am I mistaken, or is that something that should be fixed?
(It looks like this could be fixed by only removing changesets if they exist since e.g. at least 3 days)

Thanks.

@Ten0 Ten0 linked a pull request Aug 8, 2024 that will close this issue
@mgorski-mg
Copy link
Owner

@Ten0, I think you're right. Thanks for the PR. I added comments in your PRs. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants