Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no translated compendium after activating the module #25

Open
LEronsn opened this issue Aug 2, 2024 · 11 comments
Open

There are no translated compendium after activating the module #25

LEronsn opened this issue Aug 2, 2024 · 11 comments

Comments

@LEronsn
Copy link

LEronsn commented Aug 2, 2024

I installed the module as described, also activated babele and german core. Set the language to german, but when I looked in the compendium folder, all I found were the original english compendium. Do I need to do something more?

All is up to date, the dnd system and the modules.

Thanks in advance.

@Szerina92
Copy link
Contributor

Hello there! Have you checked the setting of the modules?
There is a setting for the translation of the compendium.
image

@LEronsn
Copy link
Author

LEronsn commented Aug 4, 2024

Hi! Jep, done this, but still no translation 😕
Screenshot_20240804_113237_Chrome
Screenshot_20240804_113255_Chrome

@Szerina92
Copy link
Contributor

That's weird! I just tried a clean installation and everything worked out.
Are there any critical errors in the console when you load the game world in? You open it with F12 in the client - may be different for some browsers.

@yourfate
Copy link

yourfate commented Aug 4, 2024

Same issue here. I think I have installed it all correctly.

My settings:

image

image

image

image

@Szerina92
Copy link
Contributor

Szerina92 commented Aug 4, 2024

I can't reconstruct the problem on my system (I may not even be of big help anyways).
Same as mentioned above, are there any errors loading into the world?
Does it load in properly
image

That's weird! I just tried a clean installation and everything worked out. Are there any critical errors in the console when you load the game world in? You open it with F12 in the client - may be different for some browsers.

@yourfate
Copy link

yourfate commented Aug 4, 2024

I found some errors in the console:

Error: Babele.get is deprecated, use game.babele instead
Deprecated since Version 3
Backwards-compatible support will be removed in Version 4
    logCompatibilityWarning foundry-esm.js:4609
    get babele.js:218
    <anonymous> babele.js:14
    #call foundry.js:632
    callAll foundry.js:589
    initialize foundry.js:8979
    call_wrapped libWrapper-wrapper.js:507
    libWrapperInit libWrapper-api.js:805

Also:

Babele: Error: Directory modules/FoundryVTT-dnd5e-DE/compendium/de does not exist or is not accessible in this storage location

I guess it looks for a dir named de in the compendium folder.

@Szerina92
Copy link
Contributor

The first one is fine, that's just a "warning", but it does not affect the process. (Yellow is fine)

The second one, that might be the problem! Probably a red error msg(?)

Babele: Error: Directory modules/FoundryVTT-dnd5e-DE/compendium/de does not exist or is not accessible in this storage location

Just don't understand why it does behave like that, I will ask around!

@yourfate
Copy link

yourfate commented Aug 4, 2024

Moving all the .json files in the compendium folder into a subfolder named de makes it work.

@yourfate
Copy link

yourfate commented Aug 4, 2024

Oh, maybe it is related to this: https://gitlab.com/riccisi/foundryvtt-babele/-/tree/master?ref_type=heads#translations-files-loading

I installed this before installing babele, so maybe it didn't auto-register the folder correctly. Then, when selecting the folder manually, it expects the files in a subdirctory of the selected folder, with no way for me to configure that in the UI.

@LEronsn
Copy link
Author

LEronsn commented Aug 5, 2024

Moving all the .json files in the compendium folder into a subfolder named de makes it work.

Yep. That helped. Thanks for the advice

@ptognotti
Copy link

ptognotti commented Jan 13, 2025

In line 93 in "dnd5e-de.js" you compare the game the module's language to "game.i18n.lang" which is "en" for me. My language in the menu was set to german though. That line is in my opinion completely not required and messes things up when the game is in english but clients choose german in their settings. Maybe just remove it.

This comparison is not required and causes issues when the game is not in german the the user's settings are german
game.i18n.lang === module_lang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants