Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core classes (ex TaskRun) should return abstract interface classes whenever possible #35

Open
spaceisfun opened this issue Oct 2, 2020 · 0 comments
Open

Core classes (ex TaskRun) should return abstract interface classes whenever possible #35

spaceisfun opened this issue Oct 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@spaceisfun
Copy link
Member

A recent commit c4819fe, changed the TaskRun::TaskOutput parameter type from List to LockingList. Ideally the core classes such as TaskRun return abstract classes like IList, so that this wouldn't have been a breaking change.
@spaceisfun spaceisfun added the enhancement New feature or request label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spaceisfun