Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options specifying behavior when filter is missing. #3

Open
Eskibear opened this issue Mar 14, 2024 · 0 comments
Open

Add options specifying behavior when filter is missing. #3

Eskibear opened this issue Mar 14, 2024 · 0 comments

Comments

@Eskibear
Copy link
Member

Eskibear commented Mar 14, 2024 •
edited
Loading

Just want to call out here, In .NET, we have an option to decide the behavior when filter can not be found:
https://github.com/microsoft/FeatureManagement-Dotnet/blob/main/src/Microsoft.FeatureManagement/FeatureManagementOptions.cs
The default behavior is throwing exception instead of slient error.

And there was a discussion about this design: microsoft/FeatureManagement-Dotnet#248

But it's not necessary to make JS FM lib completely same as .NET FM lib. Just put it here, for your reference.

Originally posted by @zhiyuanliang-ms in #1 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eskibear