Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout on pop-up sign in not centered/jsutified #5

Open
JamesEdmonds89 opened this issue Nov 27, 2017 · 8 comments
Open

Layout on pop-up sign in not centered/jsutified #5

JamesEdmonds89 opened this issue Nov 27, 2017 · 8 comments

Comments

@JamesEdmonds89
Copy link

When I get a pop-up sign in dialogue box, such as connecting to Exchange Online powershell in my below example, the layout does not look great as you can see:
image

The sign in boxes aren't centered, and the copyright bar at the bottom of the page just hovers in the middle, rather than aligning with the bottom of the window.

@PhilipHaglund
Copy link

PhilipHaglund commented Nov 29, 2017

It's related to the footer. If you change the position property in the footer to "fixed;" instead of "relative;" located in:
@media (max-width: 600px), (max-height: 392px){
...
#footer {
....
position: fixed;

image

@JamesEdmonds89
Copy link
Author

Ok will have a look for that and give it an adjustment.

Would you expect the main body of the page to be centered, or more to the left as it seems to be in both our cases?

Also, do you have any guides on how to amend the footer to include the links you have in yours, or is that something you just did yourself? I'd love to add a change password link to our footer.

@0acff4be45
Copy link

You could use this to add a change password link:

Set-AdfsGlobalWebContent -HelpDeskLink "https://sts.domain.com/adfs/portal/updatepassword/" -HelpDeskLinkText “Change Password”

You can use -PrivacyLink as well

@JamesEdmonds89
Copy link
Author

Adjusting position to fixed works perfectly!

Noted on adding -HelpDeskLink, will try that next.

I am keen to know your guys thoughts on the centering of the main body content, as the Microsoft sign in dialogue has these centered horizontally, and just seems odd the ADFS ones are slightly to the left.

Cheers.

@PhilipHaglund
Copy link

PhilipHaglund commented Nov 29, 2017

If you want my take and fixes for this AdfsWebCustomization, check out my ADFS Repo. Example screenshots available.

Fixes included:

  • Transparent Footer as the login.microsoftonline.com page.
  • Copyright removed and replaced with "Home", "Change Password" and "Mailto:Help" links.
  • Align the boxes and Submit and Cancel buttons for the "Change Password" site.
  • "Small Resolution screens" or Mobile devices have a white footer with black icons (text) instead of a transparent black footer with white icons (text).

@JamesEdmonds89
Copy link
Author

Phil, your commit looks good, and I love the transparent footer to fall in line with Microsoft's own login pages.

Not sure if I should raise as an issue on your project or not, but my only last gripe is the centering of the dialogue boxes on small resolution windows/devices.
Microsoft's login pages have the boxes centered within the window, and I think if ADFS was the same, then that would be all aspects I can think of now matching Microsoft's design. :D

@PhilipHaglund
Copy link

PhilipHaglund commented Nov 30, 2017

I think the best way is to create an issue on my project to keep this issue clean from other things. Do this and provide examples (screen dumps) on the working Azure AD Sign-in page and the non-working ADFS Sign-in page and perhaps I can figure it out.

@JamesEdmonds89
Copy link
Author

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants