From 729de2b5a7dee1ee538a06d6c72578eaa7f3df9f Mon Sep 17 00:00:00 2001 From: Michael Kubacki Date: Fri, 2 Dec 2022 19:08:56 -0500 Subject: [PATCH] label-issues: Invert functional impact label logic (#48) Fixes #47 The checkbox exposed to contributors in a PR to determine whether the PR has a functional impact states: "Impacts functionality?" This uses positive logic to simplify understanding by the user. Currently the `impact:non-functional` label is applied if the checkbox is checked. This change inverts the logic to apply the label as expected. Signed-off-by: Michael Kubacki --- .sync/workflows/config/label-issues/regex-pull-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.sync/workflows/config/label-issues/regex-pull-requests.yml b/.sync/workflows/config/label-issues/regex-pull-requests.yml index 175d3c3e..26d6e5d3 100644 --- a/.sync/workflows/config/label-issues/regex-pull-requests.yml +++ b/.sync/workflows/config/label-issues/regex-pull-requests.yml @@ -12,7 +12,7 @@ impact:breaking-change: - '\s*-\s*\[\s*[x|X]\s*\] Breaking change\?' impact:non-functional: - - '\s*-\s*\[\s*[x|X]\s*\] Impacts functionality\?' + - '\s*-\s*\[\s*(?![x|X])\s*\] Impacts functionality\?' impact:security: - '\s*-\s*\[\s*[x|X]\s*\] Impacts security\?'