Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Item process experience #249

Open
4 tasks
SwordFaith opened this issue Mar 10, 2021 · 0 comments
Open
4 tasks

Item process experience #249

SwordFaith opened this issue Mar 10, 2021 · 0 comments
Labels
design doc enhancement New feature or request Epic

Comments

@SwordFaith
Copy link
Contributor

SwordFaith commented Mar 10, 2021

Introduction

Marketplace item with access control has updated in v1.6 version of MP rest-server. It will be more user-friendly to make users not only can view templates and use templates in OpenPAI platform, but also directly edit, copy, view access details, and leverage access control ability in creating process.

Issues / Motivations

Proposals / Solutions

Item Detail Page Overview:
MPItemDetail

Edit

  1. Edit template name or description or other metadata
    1. Name
    2. Summary
    3. Description (Editable, use description template by default)
    4. Access Control
  2. Don't touch protocol (Add update protocol function or VCS for protocols in a future version)
  3. Hide create time,display last edit time
  4. Use edit state for item detail page, switch to form input style page, reuse to create item.

Copy

Copy Dialog:
MPItemCopyDialog

  1. Copy button with the same position as Delete button.
  2. Behavior:
    1. Change author name to the current user, (what will happen with unauthorized prerequisites / SKU mismatch/storage / virtual cluster ? Maybe add check and highlight, have troubleshooting)
    2. Pop a window to rename, and change access control (same as origin by default)
    3. Post to MP rest-server (need record fork from which item ?)

View

  1. Show item access control info (private/public/shared), for shared status, users can click on to view detail shared-to info
    1. where to display
    2. display behavior
      1. public/private can't click
      2. shared(restricted/protected): click to show detail share-to info
    3. edit behavior: toggle in edit state
  2. If select all group, shouldn't convert implicitly to public access.

Create

MPItemCreateAccessControl

  1. Add access control option in the current item creation process, default is public, may share a react component with "save to template" access control selector. Save Template Experience Improvement Design #253

Work Plan

Process Check List

  • Item 1
  • Item 2

Test cases

  • Test 1
  • Test 2
@SwordFaith SwordFaith added enhancement New feature or request Epic labels Mar 10, 2021
@SwordFaith SwordFaith mentioned this issue Mar 10, 2021
40 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design doc enhancement New feature or request Epic
Projects
None yet
Development

No branches or pull requests

1 participant