Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP colors issue. Not matching when braces opened. #12

Open
phpbits opened this issue Nov 26, 2018 · 2 comments
Open

PHP colors issue. Not matching when braces opened. #12

phpbits opened this issue Nov 26, 2018 · 2 comments
Assignees

Comments

@phpbits
Copy link

phpbits commented Nov 26, 2018

Trying to switch to VSCode from Sublime but the colors doesn't match. I've attached images from both editors. Thanks!

Incorrect on VSCode
screen shot 2018-11-26 at 4 58 47 am

Here's how it should look.
screen shot 2018-11-26 at 4 59 24 am

@mihai-vlc mihai-vlc self-assigned this Nov 26, 2018
@mihai-vlc mihai-vlc added the bug label Nov 26, 2018
@mihai-vlc
Copy link
Owner

mihai-vlc commented Nov 26, 2018

will have a look at this in the coming weekend
meanwhile PRs are welcome

@mihai-vlc
Copy link
Owner

I have reviewed this and the core issue is in the language processing from VSCode.

It doesn't identify the tokens correctly when the PHP code is embedded in a style tag.

image

We will need to transfer this ticket to the vscode repository to have that issue addressed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants