Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Our python datahub search client does not return correct page search results #3328

Closed
LavMatt opened this issue Feb 15, 2024 · 0 comments · Fixed by #3381
Closed

🐛 Our python datahub search client does not return correct page search results #3328

LavMatt opened this issue Feb 15, 2024 · 0 comments · Fixed by #3381
Labels
bug Something isn't working

Comments

@LavMatt
Copy link
Contributor

LavMatt commented Feb 15, 2024

Describe the bug.

The start parameter in the graphql query of our search client's search method, had until now assumed to be start page and passing a page number would return the results of size count from that page.

start actually refers to the index of individial serach results so to get page would be

"start": count * page,

need to implement the fix in the catalogue package.

This bug is presenting itself in the paginated results of find-moj-data

To Reproduce

  1. make a search with more than 20 results
  2. got to page 2
  3. see top result is 2nd from top result from previous page

Expected Behaviour

subsequent pages of search results display unique results. Should match the page results as seen in datahub UI

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants