Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update webapp guidance for AP #4181

Closed
mshodge opened this issue Apr 25, 2024 · 2 comments
Closed

✨ Update webapp guidance for AP #4181

mshodge opened this issue Apr 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools feature-request

Comments

@mshodge
Copy link
Contributor

mshodge commented Apr 25, 2024

Describe the feature request.

Based off the issues experienced in https://github.com/ministryofjustice/data-platform-support/issues/544 I thought it would be good to list where the current guidance, and templates can be improved.

Update the template to include the healthcheck

Need the following added before line 164:

--set WebApp.AlternativeHealthCheck.enabled="true" \
--set WebApp.AlternativeHealthCheck.port=9999 \

This is to prevent healthcheck issues

Update the guidance to state the port needs to be 9999

The healthcheck and other endpoints are sent to port 9999, but this normally isn't the default or norm port when people build webapps. So the guidance needs to specific that they need to use port 9999.

A good place to include this is probably where the Dockerfile is first mentioned here.

Add note to make sure user doesn't set the namespace to be the same as the repo name

The Cloud Platform namespace should be different to the github repository name the app is in; this isn't explicitly stated so I think it would be good to just mentioned in here.

Examples of working webapps using different app languages

Would be good to include a list of known, working webapps at the end of the guidance for the various types of webapp people typically create. It's very RShiny heavy at the moment, so examples of Flask, Dash and streamlit would be useful too.

Describe the context.

No response

Value / Purpose

No response

User Types

No response

@jacobwoffenden jacobwoffenden added the data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools label Apr 25, 2024
@jacobwoffenden jacobwoffenden changed the title Update webapp guidance for AP ✨ Update webapp guidance for AP May 13, 2024
@Ed-Bajo
Copy link

Ed-Bajo commented May 14, 2024

We would look into the suggestions for the guidance.

@Ed-Bajo Ed-Bajo added the bug Something isn't working label Jun 3, 2024
@Emterry Emterry self-assigned this Jul 10, 2024
@jacobwoffenden jacobwoffenden moved this from 👀 TODO to 🚀 In Progress in Analytical Platform Jul 10, 2024
@Emterry
Copy link
Contributor

Emterry commented Jul 11, 2024

@Emterry Emterry moved this from 🚀 In Progress to 🎉 Done in Analytical Platform Jul 11, 2024
@Emterry Emterry closed this as completed by moving to 🎉 Done in Analytical Platform Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools feature-request
Projects
Archived in project
Development

No branches or pull requests

4 participants