From ea7e4204b9e71f95e886ca8b1ded6e8aee050574 Mon Sep 17 00:00:00 2001
From: Adam Thorn <alt36@cam.ac.uk>
Date: Tue, 12 May 2020 12:17:17 +0100
Subject: [PATCH] Call url() with suitable options when generating $url from
 field_link

This follows the code in theme_link_formatter_link_plain() from
link.module. When the raw internal 'url' property is simply
printed, it leads to any query parameters being stripped (and I'm
assuming e.g. that URL fragments are similarly missed off) because
of the internals of how Link sanitizes URLs.

This e.g. makes it impossible to have a carousel item linking to
a YouTube video.
---
 templates/node----carousel-item.tpl.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/templates/node----carousel-item.tpl.php b/templates/node----carousel-item.tpl.php
index 0423188..d7c655a 100644
--- a/templates/node----carousel-item.tpl.php
+++ b/templates/node----carousel-item.tpl.php
@@ -1,7 +1,10 @@
 <?php
 
 if (array_key_exists('field_link', $content)):
-  $url = $content['field_link']['#items'][0]['url'];
+  # following link.module's implementation of theme_link_formatter_link_plain
+  # otherwise e.g. query params get stripped
+  $link_element = $content['field_link'][0]['#element'];
+  $url = url($link_element['url'], $link_element);
 else:
   $url = ($type == 'homepage_carousel') ? NULL : $node_url;
 endif;