Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Be able to specify and render just one or two quadrants instead of the four #2

Open
mithi opened this issue Aug 10, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed up for grabs

Comments

@mithi
Copy link
Owner

mithi commented Aug 10, 2020

Currently, when we specify the x-range the y-range of the container the default plot would be like so:

                  yRange/2
                     | 
               Q2    |      Q1
  -xRange/2 -------(0,0)--------- xRange/2
               Q3    |      Q4
                     |    
                 -yRange/2

Sometimes we only need one of the following

  • Q1
  • Q2
  • Q3
  • Q4
  • Q1 + Q2
  • Q3 + Q4
  • Q1 + Q4
  • Q2 + Q3
  • Q1 + Q2 + Q3 + Q4

We should be able to specify, so that we don't waste space in the screen that don't have markers.
I'm thinking the API would be something like:

const container = { xRange, yRange, color, opacity, quadrants }

Where quadrant is a string that could contain "Q12", "Q3", "Q1234" etc

We have to change this part

transformX = (x) => x + this.xRange / 2
transformY = (y) => this.yRange / 2 - y

to not be hard coded and be generic

@mithi mithi changed the title feature: Be able to specify and render just one or two quadrants instead of the four TODO: Be able to specify and render just one or two quadrants instead of the four Aug 10, 2020
@mithi mithi added good first issue Good for newcomers up for grabs first-timers-only help wanted Extra attention is needed and removed first-timers-only labels Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed up for grabs
Projects
None yet
Development

No branches or pull requests

1 participant