Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockChain - Piece: Trading of kitties #3

Closed
AltiMario opened this issue Feb 23, 2024 · 3 comments
Closed

BlockChain - Piece: Trading of kitties #3

AltiMario opened this issue Feb 23, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@AltiMario
Copy link
Contributor

AltiMario commented Feb 23, 2024

DApp ensures Kitties can be traded between the users. Ensure ownership is transferred successfully once trading is completed.

@AltiMario AltiMario moved this to Backlog in TuxedoDapp Feb 23, 2024
@AltiMario AltiMario added this to the DApp Core milestone Feb 23, 2024
@NadigerAmit
Copy link

NadigerAmit commented Feb 25, 2024

Both blockchain side and wallet side implementation is done as below

  1. Blockchain side : https://github.com/mlabs-haskell/Tuxedo/blob/4caa90a2cc88b70973427c55c154f5af224118b8/wardrobe/tradable_kitties/src/lib.rs#L439-L44
  2. Wallet side : https://github.com/mlabs-haskell/Tuxedo/blob/4caa90a2cc88b70973427c55c154f5af224118b8/wallet/src/kitty.rs#L509-L587

This has limitations:
Since the seller and buyer will have their private keys stored in their respective wallet , if we ant to trade it involves below steps 1. Kitty need to be transferred from seller to buer , so kitty need to be signed by seller
2. Coins or money need to be transferred from the buyer to seller, so coins need to be signed by buyer.
I.e redeemers need to be included for each input .
3. How to sign the coins and kitty at the same time ;
Please see below issues : Off-Narrative-Labs/Tuxedo#169
I think solution 1 is more feasible.

@NadigerAmit
Copy link

Blockchain-side implementation is done.
Solution 1 proposed in the Off-Narrative-Labs/Tuxedo#169 seems possible in JS wallet side.
CLI-wallet side implementation is not done. May be difficult to implement on cli side. Not planning to implement in CLI wallet.

Mikhail needs to study the feasibility and propose.

@AltiMario AltiMario moved this from Backlog to In progress in TuxedoDapp Feb 26, 2024
@AltiMario AltiMario changed the title Trading of kitties Trading of kitties backend Feb 26, 2024
@AltiMario AltiMario moved this from In progress to Done in TuxedoDapp Feb 26, 2024
@NadigerAmit NadigerAmit moved this from Done to In-Review in TuxedoDapp Feb 27, 2024
@NadigerAmit NadigerAmit changed the title Trading of kitties backend BE: Trading of kitties Feb 27, 2024
@NadigerAmit NadigerAmit added the good first issue Good for newcomers label Feb 27, 2024
@NadigerAmit NadigerAmit changed the title BE: Trading of kitties BlockChain - Piece: Trading of kitties Mar 21, 2024
@NadigerAmit NadigerAmit moved this from In-Review to Done in TuxedoDapp Mar 21, 2024
@NadigerAmit
Copy link

Since blockchain-side implementation is done I moving to Done as it is already submitted in the https://github.com/mlabs-haskell/Tuxedo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

3 participants