Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcoder class should have a virtual destructor #31

Open
RussellTaylor opened this issue Dec 5, 2023 · 0 comments
Open

Transcoder class should have a virtual destructor #31

RussellTaylor opened this issue Dec 5, 2023 · 0 comments

Comments

@RussellTaylor
Copy link

Since the NewEncoder & NewDecoder factory functions return a Transcoder object, this class needs to have a virtual destructor in order for the concrete object to be deleted properly and not leak.

This simply requires adding the following line:

virtual ~Transcoder() = default;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant