Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to run without needing PSRCHIVE #2

Open
5 tasks
mlower opened this issue Jul 2, 2021 · 0 comments
Open
5 tasks

Add functionality to run without needing PSRCHIVE #2

mlower opened this issue Jul 2, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mlower
Copy link
Owner

mlower commented Jul 2, 2021

Not everyone has or is able to install the Python wrappers for PSRCHIVE. Better to add functionality so that the RM-fitting function is run on an input numpy array, as opposed to taking a psrchive object as input. Could even save a copy of the polarised spectrum to a textfile?

  • Add terminal (argparse) flag so use of psrchive is optional.
  • Add check to see if psrchive is installed.
  • Add functionality so that use of psrchive objects & functions only run if psrchive is installed.
  • Change input of fit_rotation_measure() to take a numpy array as input instead of a psrchive object.
  • Save a copy of the polarised spectrum extracted from the psrchive object (optional).
@mlower mlower self-assigned this Jul 2, 2021
@mlower mlower added the enhancement New feature or request label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant