Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling margo_provider_register multiple times with different pools #109

Open
mdorier opened this issue Mar 9, 2021 · 1 comment
Open

Comments

@mdorier
Copy link
Contributor

mdorier commented Mar 9, 2021

Mercury allows calling HG_Register multiple times on the same hg_id_t if we want to change the callback and/or the serialization functions. Looking at the margo code, I'm under the impression that if we do that via margo_provider_register and change the Argobots pool associated with the RPC, the pool won't be changed. See here: https://github.com/mochi-hpc/mochi-margo/blob/main/src/margo-core.c#L1468

@carns
Copy link
Member

carns commented Mar 15, 2021

The fix for this would be easy (just reset the fields in the existing margo_data if found). The harder part will be to create a test case :) Is there a specific example we want to verify works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants