Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modpacks with ":" in their name fail to export silently #3117

Open
3 tasks done
okunamayanad opened this issue Jan 3, 2025 · 1 comment
Open
3 tasks done

Modpacks with ":" in their name fail to export silently #3117

okunamayanad opened this issue Jan 3, 2025 · 1 comment
Labels
app Relates to Modrinth App bug Something isn't working

Comments

@okunamayanad
Copy link

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

Modrinth App 0.9.2 windows 10.0.26100

What operating systems are you seeing the problem on?

No response

Describe the bug

If you try to export a modpack with ":" in its name, Modrinth app will export a file with the name before ":" with 0 bytes

For example: "AB:C" modpack will export as "AB" and won't work (as the file is literally 0 bytes)

Steps to reproduce

  1. Create a modpack with ":" in the name
  2. Export the modpack
  3. Check the exported file
  4. See the error

Expected behavior

It should warn users about unsupported characters in their pack name for their OS

Additional context

As context: You can't create ":" in name for a file on Windows

@okunamayanad okunamayanad added app Relates to Modrinth App bug Something isn't working labels Jan 3, 2025
@EgorBron
Copy link

EgorBron commented Jan 8, 2025

+1, just creates an empty file named with part preceding the colon.

Also, when the slash appears in the modpack name, it tries to open a file in a directory named as the anything before last slash!

The question and exclamation mark, and, maybe other special characters, also throw the filename syntax error.

Image

Image

Image

Image

Image

(error in Russian because my Windows is in Russian)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App bug Something isn't working
Development

No branches or pull requests

2 participants