Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor vs node_modules #25

Open
ivoba opened this issue May 12, 2021 · 2 comments
Open

vendor vs node_modules #25

ivoba opened this issue May 12, 2021 · 2 comments

Comments

@ivoba
Copy link
Collaborator

ivoba commented May 12, 2021

@tfavetto Having bootstrap & barlow font in vendor and in node_modules is somehow double.

Why are this deps double?
I would expect just to use package.json deps and node_modules as source files for the Gruntfile.

@tfavetto
Copy link
Contributor

@ivoba there is a tool corresponding with moga theme to make everything editable in backend. It reads the variables and allows you to change colors & co. That needs the BS 5 files to be included :)

@ivoba
Copy link
Collaborator Author

ivoba commented May 31, 2021

@tfavetto the module https://github.com/moga-kit/moga-module seems to only override _custom_variables.scss & _custom_styles.scss, so no need to double bootstrap in vendor, imho.
Also the module uses node_modules as well

$sBootstrapScssPath = $oConfig->getViewsDir(true) . "moga/node_modules/bootstrap/scss";

Having the node_modules online is also a smell in my opinion but thats another story :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants