Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store approvedDate date in MapInfo table #903

Open
tsa96 opened this issue Feb 7, 2024 · 2 comments
Open

Store approvedDate date in MapInfo table #903

tsa96 opened this issue Feb 7, 2024 · 2 comments
Labels
Size: Small Something that may take a day at most to do.

Comments

@tsa96
Copy link
Member

tsa96 commented Feb 7, 2024

We keep this in the map submission table within the dates field, but normally don't want to include that data for approved maps. It would make a lot of sense to just store an approvedDate date in the MapInfo table alongside creationDate.

I would do this in my current PR, but it's enormous enough as-is, so leaving for afterwards.
@tsa96 tsa96 added the Size: Small Something that may take a day at most to do. label Feb 7, 2024
@tsa96
Copy link
Member Author

tsa96 commented Feb 7, 2024

Left a comment in map-info.component.ts in a place that should use this in future.

@tsa96 tsa96 moved this to Todo in Map Submission May 27, 2024
@tsa96
Copy link
Member Author

tsa96 commented Nov 15, 2024

Should be used in map-entry.ts Panorama component as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Size: Small Something that may take a day at most to do.
Projects
Map Submission
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsa96