From 5ad70140515c1765b88a1b38fb4e034649ab2e97 Mon Sep 17 00:00:00 2001
From: Kevin Schaper <kevinschaper@gmail.com>
Date: Tue, 17 Oct 2023 14:47:38 -0700
Subject: [PATCH] Fixes the constraint spec for posting to the compare endpoint
 (#412)

I used Query to add some constraints to the compare by post endpoint,
but that moved the subject & object lists to query string. Using a
pydantic class as the argument to the post solves this.
---
 backend/src/monarch_py/api/additional_models.py | 9 ++++++++-
 backend/src/monarch_py/api/semsim.py            | 9 ++++-----
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/backend/src/monarch_py/api/additional_models.py b/backend/src/monarch_py/api/additional_models.py
index 9fed38756..24ae01687 100644
--- a/backend/src/monarch_py/api/additional_models.py
+++ b/backend/src/monarch_py/api/additional_models.py
@@ -1,5 +1,7 @@
+from typing import List
+
 from fastapi import Query, Request
-from pydantic import BaseModel
+from pydantic import BaseModel, Field
 
 
 class PaginationParams(BaseModel):
@@ -9,3 +11,8 @@ class PaginationParams(BaseModel):
 
     class Config:
         arbitrary_types_allowed = True
+
+
+class CompareRequest(BaseModel):
+    subjects: List[str] = Field(..., title="List of subjects for comparison")
+    objects: List[str] = Field(..., title="List of objects for comparison")
diff --git a/backend/src/monarch_py/api/semsim.py b/backend/src/monarch_py/api/semsim.py
index 8e28762b8..a34b1b8bd 100644
--- a/backend/src/monarch_py/api/semsim.py
+++ b/backend/src/monarch_py/api/semsim.py
@@ -1,6 +1,8 @@
 from typing import List
 
 from fastapi import APIRouter, Path, Query
+
+from monarch_py.api.additional_models import CompareRequest
 from monarch_py.api.config import oak
 
 router = APIRouter(tags=["semsim"], responses={404: {"description": "Not Found"}})
@@ -35,10 +37,7 @@ def _compare(
 
 
 @router.post("/compare")
-def _post_compare(
-    subjects: List[str] = Query(...,title="List of subjects for comparison"),
-    objects: List[str] = Query(...,title="List of objects for comparison")
-):
+def _post_compare(request: CompareRequest):
     """
         Pairwise similarity between two sets of terms <br>
         <br>
@@ -50,4 +49,4 @@ def _post_compare(
     }
     </pre>
     """
-    return oak().compare(subjects, objects)
+    return oak().compare(request.subjects, request.objects)