Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README has dangerous YAML syntax #62

Open
cmungall opened this issue Aug 22, 2024 · 0 comments
Open

README has dangerous YAML syntax #62

cmungall opened this issue Aug 22, 2024 · 0 comments

Comments

@cmungall
Copy link
Member

cmungall commented Aug 22, 2024

the README has examples

foo: True

that Yaml is not YAML 1.2.2 safe

https://stackoverflow.com/questions/53648244/specifying-the-string-value-yes-in-yaml

I assume you are using pyyaml which is not yet 1.2

True is interpreted as a bool
as soon as you switch to 1.2 (or use a different yaml parser, or use rust…) these are interpreted as strings

and if you are not using linkml with its validation, these will be interpreted as

>>> bool("False")
True

you won’t see any warnings but pheval will silently run using a different config than what you intended…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant