Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity in build instructions #71

Closed
ordtrogen opened this issue Jun 14, 2018 · 5 comments
Closed

Ambiguity in build instructions #71

ordtrogen opened this issue Jun 14, 2018 · 5 comments

Comments

@ordtrogen
Copy link

  1. Should there be a space before the number of CPUs or not?

  2. Are those backticks/backquotes, or should they be normal single quotation marks? AFAIK the backtick has a special function in many shells, but it doesn't look like that's what's intended here

image

@erciccione
Copy link
Contributor

  1. AFAIK it makes no difference
  2. I think here backquotes are used because for consistency with the markdown structure (since all code should go between backquotes) and they are not shell instructions

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 14, 2018

  1. I think it's the same with or without space, but it's commonly used together ie: make -j8 And the numbers is the available CPU cores +1 or +2.
  2. It's commonly accepted to use `` to represent code.

@anonimal
Copy link
Collaborator

@ordtrogen The build instructions have changed. Build instructions are now in the kovri README now. We'll need translations though, just like in monero-project/kovri#906.

kovri-site should adjust to these changes a.s.a.p so we save time for translators.

@anonimal anonimal mentioned this issue Jun 29, 2018
14 tasks
@anonimal
Copy link
Collaborator

anonimal commented Jul 5, 2018

Referencing #79

@anonimal
Copy link
Collaborator

Resolved, at least for non-Russian languages. Russian changes to kovri-docs will happen when someone comes along to do them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants