Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Multi-touch #1348

Open
VOLOHIT opened this issue Mar 25, 2024 · 18 comments
Open

[Feature request]: Multi-touch #1348

VOLOHIT opened this issue Mar 25, 2024 · 18 comments

Comments

@VOLOHIT
Copy link

VOLOHIT commented Mar 25, 2024

Is your feature request related to a problem? Please describe.

Introduction of full support for touch screens (Multi-touch).

Describe the solution you'd like

I want control from the phone not to be limited to one cursor, which cannot make multiple clicks in different places on the screen. This makes it very difficult to interact in games that initially support touch devices (Genshin Impact is one of the most common ones).

Describe alternatives you've considered

Yeah

Screenshots

No response

@WesleyVanNeck
Copy link

Is already in it but it's disabled in source code rn

@VOLOHIT
Copy link
Author

VOLOHIT commented Mar 26, 2024

Is already in it but it's disabled in source code rn

Thank you, I looked for more information and found a Chinese client where this function is available.

@pajaritia
Copy link

@VOLOHIT can you tell me how to search for the client that has Multi-Touch enabled? I have not been able to find any :(
I wish they would just enable it as an optional setting for the regular Android Moonlight

@Apkeniqo
Copy link

Apkeniqo commented Apr 4, 2024

@VOLOHIT can you tell me how to search for the client that has Multi-Touch enabled? I have not been able to find any :( I wish they would just enable it as an optional setting for the regular Android Moonlight

Here is the modified version: https://b23.tv/wbJWhLj
it has more useful features but may not have English translation

@TrueZhuangJia
Copy link

Hi guys, I created a fork to implement multi-touch on iOS
https://github.com/TrueZhuangJia/moonlight-ios-NativeMultiTouchPassthrough/tree/Moonlight-iOS-ZWM

@max20091
Copy link

max20091 commented Jul 9, 2024

I have to bring this up because the touch codes already exist in the app but the developer doesn't enable it.
This fork fix "a line of code" which isn't enabled and multi-touch magically works: https://github.com/DanpGamer/sunlight-android

Be aware that many games doesn't natively support multi-touch, games running through certain Android emulators should have touch working.

@ClassicOldSong
Copy link

Here's a globalized version of Axixi's fork combined with some of my own fixes. You can try this for much more features built-in including multi touch support

https://github.com/ClassicOldSong/moonlight-android/releases

@kayakyakr
Copy link

Here's a globalized version of Axixi's fork combined with some of my own fixes. You can try this for much more features built-in including multi touch support

https://github.com/ClassicOldSong/moonlight-android/releases

Looked through your commits and your implementation looks good. May I suggest cherry picking the main commits into a PR?

@ClassicOldSong
Copy link

Here's a globalized version of Axixi's fork combined with some of my own fixes. You can try this for much more features built-in including multi touch support
ClassicOldSong/moonlight-android/releases

Looked through your commits and your implementation looks good. May I suggest cherry picking the main commits into a PR?

Sure, there's already a PR for trackpad fix opened, but the main repo here hasn't seen any update for months I'm afraid adding too much features at once may be chaotic

@TrueZhuangJia
Copy link

Here's a globalized version of Axixi's fork combined with some of my own fixes. You can try this for much more features built-in including multi touch support
https://github.com/ClassicOldSong/moonlight-android/releases

Looked through your commits and your implementation looks good. May I suggest cherry picking the main commits into a PR?

Facts about Axixi:

  • He started modifiying moonlight-android 12 months ago, gaining at least ten thousand followers. But his version was not "open-sourced" until I revealed him as a thief on Bilibili in recent days.

  • He asked me a lot of questions on QQ( IM-chat software) in order to understand how the feature I created works, then imitated that by his own coding and make the video as if it is created by himself

  • If anybody wanna upstream any of Axixi's features, be careful. You have no idea where those features came from. Go to the Axixi's fork, He merged the whole-year coding into just 1 initial commit, for what? Have you seen any real open source developers did this?
    image
    What is Axixi trying to hide ? The true brilliant ideas & codings from other geniune developers!

@ClassicOldSong
Copy link

@TrueZhuangJia I guess he just don't know how to use Git. Also, his coding isn't great, but things work. I've rewritten some of his implementations already. As I have checked, most features come from PRs that hasn't been merged yet.

@TrueZhuangJia
Copy link

@TrueZhuangJia I guess he just don't know how to use Git. Also, his coding isn't great, but things work. I've rewritten some of his implementations already. As I have checked, most features come from PRs that hasn't been merged yet.

He doesn't know how to git? Well, Additional facts about AXX:

  • Full-time android engineer for years.
  • He recommended me to use Source Tree to git, when I was one of his fans, and getting started to code moonlight.

most features come from PRs that hasn't been merged yet.
That's what he was doing, one of the features was mine, which he imitated by his own code... You know he never acknowledged credits from other developers. He even deleted my comment under his video that stated I am the original creator.

@ClassicOldSong
Copy link

Would you please point out which part was yours? I'll add an acknoledgement in the README and release page. Also I don't mind where the commits come from, as this project is licensed under GPL, all modifications to the project should and are required to be open sourced.

Though I'll only PR my own modifications, the codebase from Axixi is totally usable and should be upstreamable, just Axixi's removal of credits from other developers should be blamed.

If he really is a full time Android developer, his coding skill is indeed a disaster...

@TrueZhuangJia
Copy link

TrueZhuangJia commented Jul 18, 2024

@ClassicOldSong
Thank you so much.
This is my PR:
#1364
and my android repo:
https://github.com/TrueZhuangJia/moonlight-android-Enhanced-MultiTouch

The feature I created makes native multi-touch point spawned within a particular area (usually the right part of screen) move slower or faster on remote PC,
It's useful for tweaking view rotation sensitivity, for PC games with touch-screen UI like Mihoyo series: Genshin Impact, HK: Star Trail, HK: 3rd...

This is the video where I called AXX a thief
【阿西西: 我撒谎、偷窃、白嫖,但我是大佬Up主-哔哩哔哩】 https://b23.tv/QO2c5fF

@TrueZhuangJia
Copy link

Would you please point out which part was yours? I'll add an acknoledgement in the README and release page. Also I don't mind where the commits come from, as this project is licensed under GPL, all modifications to the project should and are required to be open sourced.

Though I'll only PR my own modifications, the codebase from Axixi is totally usable and should be upstreamable, just Axixi's removal of credits from other developers should be blamed.

If he really is a full time Android developer, his coding skill is indeed a disaster...

@ClassicOldSong
If he really is a full time Android developer, his coding skill is indeed a disaster...

Totally agreed! That's what I thought about his coding:

image

The original post on Bilibili:
【"阿西西的日常" : 游戏串流界小偷、假大佬、毒瘤up主】 https://b23.tv/79NBaWg

@ClassicOldSong
Copy link

Cited.

@TrueZhuangJia
Copy link

TrueZhuangJia commented Jul 21, 2024

Cited.

@ClassicOldSong 有兴趣的话可以来我们 串流重生基地Q群。
904820296
进群的话, 请注意收发管理员@你发的验证码。

除了我之外, 这两个fork的修改者也都在群里
https://github.com/WACrown/moonlight-android
https://github.com/qiin2333/Sunshine

@ClassicOldSong
Copy link

I'm sorry I rarely use QQ now...

My modifications lean towards office needs, enhanced for remote desktop usage, which isn't quite matched to most gaming setups.

Thanks for the invitation though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants