Develop RabbitMQ component for Delay Queue API; 为 Delay Queue API 开发 RabbitMQ 组件

[shawnh2]

What would you like to be added:

Develop a new component for Delay Queue API.

• RabbitMQ

Why is this needed: refer to issue #840

We need more components to make this API useful

[shawnh2]

Do I have to register the component in cmd/layotto/main.go, cmd/layotto_multiple_api and cmd/layotto_without_xds in NewRuntimeGrpcServer? Cause delay_queue/azure/servicebus does not.

[seeflood]

Do I have to register the component in cmd/layotto/main.go, cmd/layotto_multiple_api and cmd/layotto_without_xds in NewRuntimeGrpcServer? Cause delay_queue/azure/servicebus does not.

You don't have to

[shawnh2]

It seems that the module github.com/dapr/components-contrib v1.5.2 need change to a new version, becasue it doesn't support message TTL in pubsub/rabbitmq util this PR.

[seeflood]

@ShawnHXH Which version do you want to upgrade to?
It's OK to upgrade the module, but please make sure there are no incompatibilities

[shawnh2]

@ShawnHXH Which version do you want to upgrade to? It's OK to upgrade the module, but please make sure there are no incompatibilities

The latest version of github.com/dapr/components-contrib (v1.9.6) does not support this features yet, so I have to wait the next release.

[seeflood]

@ShawnHXH OK

[Xunzhuo]

/good-first-issue cancel
/help-wanted cancel

[shawnh2]

@seeflood Hi, the latest version of github.com/dapr/components-contrib (v1.10.1) has been released, now it supports delay queue for rabbitmq.

But a conflict has been found, in v1.10.1, the state/cloudstate has been canceled, should we remove this from factory?

layotto/cmd/layotto/main.go

Lines 386 to 388 in 7abad2f

	runtime_state.NewFactory("cloudstate.crdt", func() state.Store {
	return cloudstate.NewCRDT(loggerForDaprComp)
	}),

Or have another purposes of using it?

[seeflood]

@ShawnHXH Ok, we can remove it. As far as I know, there's no user using this component now

[shawnh2]

@seeflood hi, before I implement this component, I upgrade dapr/components-contrib from v1.5.2 to v1.10.1.

It solved some conflicts and incompatibilities.

[shawnh2]

@seeflood Hello again, there're few things we need to talk about before this upgradation.

---

First,
layotto need to upgrade Go version from v1.18 => v1.19 (let's say v1.19.1) nor this upgradation won't pass the CI; because:

• dapr/components-contrib v1.10.1 require minimal Go version of >1.19, nor some dependencies may fail during go-build
• that means all the go versions in .github/workflow also need to change

I wanna make sure that if it is okay for layotto to do that?

---

Second,
When I'm testing with the CodeCov, something funny happend:

The CodeCov workflow is not using Go v.1.19, even though I've changed all the versions in workflow config.
After I checked, this CodeCov runs directly using make command,

So I was wondering what's version of Go in this process? And how to alter it? Can you gimme some hints?

---

Thanks!

[wenxuwan]

@seeflood Hello again, there're few things we need to talk about before this upgradation.

First, layotto need to upgrade Go version from v1.18 => v1.19 (let's say v1.19.1) nor this upgradation won't pass the CI; because:

• dapr/components-contrib v1.10.1 require minimal Go version of >1.19, nor some dependencies may fail during go-build
• that means all the go versions in .github/workflow also need to change

I wanna make sure that if it is okay for layotto to do that?

Second, When I'm testing with the CodeCov, something funny happend: The CodeCov workflow is not using Go v.1.19, even though I've changed all the versions in workflow config. After I checked, this CodeCov runs directly using make command,

So I was wondering what's version of Go in this process? And how to alter it? Can you gimme some hints?

Thanks!

Due to the user's internal version, layotto should not be able to directly upgrade to golang1.19 at present. You can submit a pr first, and then let's see together what features dapr relies on golang1.19.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.