Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work with socket.io version 3/4 #10

Closed
N00nDay opened this issue Feb 19, 2021 · 2 comments
Closed

Does not work with socket.io version 3/4 #10

N00nDay opened this issue Feb 19, 2021 · 2 comments

Comments

@N00nDay
Copy link

N00nDay commented Feb 19, 2021 •
edited
Loading

Does not work with socket.io version 3/4. Is there any road map for updating this to work with version 3/4?
@N00nDay N00nDay changed the title Does not work with socket.io version 3 Does not work with socket.io version 3/4 Mar 20, 2021
@N00nDay
Copy link
Author

N00nDay commented Mar 20, 2021

After digging into this. All that needs to be done is update socket.io-adapter package and all works great. Whoever the maintainer is just needs to do that and all will work.

@asabhaney
Copy link
Member

asabhaney commented Mar 22, 2021 •
edited
Loading

Made some fixes in this PR: #13. It doesn't address socket.io v3/4 compatibility, but this library is essentially unmaintained except for patches. Happy to accept PRs or transfer to a new maintainer though.

@N00nDay N00nDay closed this as completed Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asabhaney @N00nDay