Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type annotations / hints #355

Open
g-k opened this issue Sep 21, 2020 · 1 comment
Open

add type annotations / hints #355

g-k opened this issue Sep 21, 2020 · 1 comment
Milestone
Unplanned

Comments

@g-k
Copy link
Contributor

g-k commented Sep 21, 2020

e.g. with dataclass or typeddict from the stdlib or if botocore provides types.

This would prevent issues and make it clearer what's being passed around.

We can try to infer types with https://monkeytype.readthedocs.io/en/latest/generation.html at a quick pass I didn't see an obvious way to invoke the frost CLI.
@g-k g-k changed the title add type annotations add type annotations / hints Oct 12, 2020
@hwine
Copy link
Contributor

hwine commented Oct 12, 2020

This ticket covers ways to update legacy code. For all new code, use of type hints is encouraged.

@ajvb ajvb added this to the Unplanned milestone Nov 10, 2020
g-k pushed a commit that referenced this issue Nov 11, 2020
add type annotations to cache.py
01826af 
refs: #355
@g-k g-k mentioned this issue Nov 11, 2020
Merged
g-k added a commit that referenced this issue Nov 12, 2020
@g-k
Update cache (#413)
70f059a 
* add type annotations to cache.py

refs: #355

* cache: remove unused 'import py'

* cache: replace string interpolation with f-string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@hwine @g-k @ajvb