Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AWS resource calls into classes #418

Open
ajvb opened this issue Nov 19, 2020 · 0 comments
Open

Refactor AWS resource calls into classes #418

ajvb opened this issue Nov 19, 2020 · 0 comments

Comments

@ajvb
Copy link
Contributor

ajvb commented Nov 19, 2020

from this discussion: #417 (comment)

Currently, there is some brittleness around how our AWS resource calls and the id extraction are separated from each other.

This is currently leading to vague and brittle get_resource_id() functions that parameterize uses to get the test id.

Along side this, there are what amount to hacks for dealing with "resources" that are lists or do not exist (i.e. https://github.com/mozilla/frost/pull/417/files#diff-ee242f021608b58d502ee9c4c6273c6145f18e6703f8329b3799c50db5c8fe95R155)

As a result, it seems like it may make sense to transform the resources.py functions into classes (dataclasses, boto3 classes, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant