Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint our dockerfiles #435

Open
hwine opened this issue Jan 19, 2021 · 2 comments
Open

Lint our dockerfiles #435

hwine opened this issue Jan 19, 2021 · 2 comments

Comments

@hwine
Copy link
Contributor

hwine commented Jan 19, 2021

Consensus was to add hadolint, but we probably have tuning to do. Our current Dockerfile produces these errors:

Dockerfile:13 DL3005 Do not use apt-get upgrade or dist-upgrade
Dockerfile:13 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Dockerfile:13 DL3009 Delete the apt-get lists after installing something

Do we want to follow the guidance, or ignore these?

  • DL3005 - best practice, per Docker
  • DL3008 - another best practice from Docker
  • DL3009 - ibid
@hwine
Copy link
Contributor Author

hwine commented Jan 19, 2021

@ajvb @g-k See above for current Dockerfile linting output in frost. Some of those are our common practices.

@hwine
Copy link
Contributor Author

hwine commented Jan 20, 2021

related- see also this in progress RFC -- improvements welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant