Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change our current progressbar package #211

Closed
Nebelhom opened this issue May 22, 2014 · 12 comments
Closed

Change our current progressbar package #211

Nebelhom opened this issue May 22, 2014 · 12 comments

Comments

@Nebelhom
Copy link
Collaborator

Our current progressbar library is not maintained any more (last update 2011), has some shortcomings with regards to unknown file sizes (see #194 ) and is not easily extendible.

It might be best to switch to a new library here and while we're at it, maybe take a lightweight one that is easily extendible and fit it to our needs.

Whimboo has already made a suggestion:

https://pypi.python.org/pypi/progress/1.2

Last update was Nov 2013, it looks fairly lightweight and for our most current issue, it has the option of using a spinner instead of a progressbar, if we do not know the file size.

Are there any other suggestions? We could always start from scratch... but I, at least, realistically cannot guarantee that I will have consistently time to write a completely new package. If anyone else fancies that, feel free to comment.

@Nebelhom
Copy link
Collaborator Author

@whimboo @davehunt

FYI.

Looks like someone picked up the old progressbar package, forked it from the source and carried it on.

https://pypi.python.org/pypi/progressbar2

@whimboo
Copy link
Contributor

whimboo commented May 13, 2015

Yeah, I noticed that again today after forgetting about your comment. Looks like we have another chance! Maybe lets see what's new and if it helps us.

@whimboo
Copy link
Contributor

whimboo commented Feb 10, 2016

Nice. It may be good to check that out. Labeling issue as mentored in case someone has interest to look at this.

@whimboo
Copy link
Contributor

whimboo commented Sep 18, 2017

There is also https://github.com/tqdm/tqdm, but maybe we should just change to progressbar2, and upgrade to its latest release. It's still under active development.

@ghost
Copy link

ghost commented Oct 5, 2017

I would be interested in working on this bug! Would it still be possible to receive mentoring?

@whimboo
Copy link
Contributor

whimboo commented Oct 5, 2017

Hello @nathanielnebel. Sure, this issue is still available to pick up. And I'm happy to mentor.

Given the still open question of what to use, I would say we keep progressbar and update it to progressbar2. There should be minimal efforts necessary to do that, and would be a good starting point for you.

Let me know what kind of issues you have or if something is not clear. I will respond as soon as I can. Thanks!

@ghost
Copy link

ghost commented Oct 5, 2017

Hello @whimboo the changes are in #453 . I would say that progressbar2 was a very good choice as it required no code changes.

@whimboo
Copy link
Contributor

whimboo commented Oct 9, 2017

Hi @nathanielnebel. Thank you for doing the work, and it's good to hear that we don't need any changes in our code. I will have a look at your PR in a moment.

@whimboo
Copy link
Contributor

whimboo commented Oct 9, 2017

PR #453 got merged now.

@whimboo whimboo closed this as completed Oct 9, 2017
@whimboo whimboo added this to the 1.24 milestone Oct 9, 2017
@whimboo
Copy link
Contributor

whimboo commented Oct 9, 2017

@nathanielnebel in case you are interested to contribute a bit more please let me know and we can certainly find a new issue for you, or maybe you can find yourself from the list of open ones.

@ghost
Copy link

ghost commented Oct 9, 2017

@whimboo If there are any issues that you think would be important to resolve let me know and I will get to work on some fixes!

@whimboo
Copy link
Contributor

whimboo commented Oct 12, 2017

@nathanielnebel, issue #400 is for our unit tests, but it would be good to see it fixed. In case you are generally interested in Python we also have other interesting projects which could need a helping hand. You could drop me an email in case we should figure out something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants