Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't condition neqo_common::log::init on cfg(test) #2368

Open
larseggert opened this issue Jan 16, 2025 · 1 comment
Open

Don't condition neqo_common::log::init on cfg(test) #2368

larseggert opened this issue Jan 16, 2025 · 1 comment

Comments

@larseggert
Copy link
Collaborator

          Turns out we cannot make the initialization conditioned on `cfg(test)`, because before a test uses one of the logging macros, the log init won't happen and there will no output :-(

Originally posted by @larseggert in #2291 (comment)

@larseggert
Copy link
Collaborator Author

Test case: RUST_LOG=debug cargo nextest run handshake_mlkem768x25519 --no-capture produces no logging output.

When a qdebug! is added to the handshake_mlkem768x25519 test, it does (and not only from that log statement, but from called functions as well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant