-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back pushlog feature #248
Comments
My initial attempt is here, as mentioned in #235 (comment): |
Does it mean that users have to install the experiment addon separately, or how does it work? |
Pushlog is only relevant for short pushlogs. Experiments run only on Nightly and Developer Edition. |
There are no WebExtensions APIs to retrieve the changeset, crash the app, and achieve other unimplemented features, so I think we need a separate experiment extension anyway. AFAIK the regular extension and experiment cannot be combined. |
Maybe it's faster to request the addition of the changeset id to |
The request could be added as dependency for bug 1215059. Maybe we can even request more data as we need for the customize titlebar feature. |
Sure the |
Which |
Yes, I meant the |
I vote for implementing the Nightly Tester Tools experiment addon! It should contain all the missing features (not just this one), which we could file as bugs later. Once they got fixed, the features going to move to the base addon. It will be available for the "blueish" Firefox (Nightly / Developer Edition) users (which should be our first class citizen IMHO). This pushlog feature should be enabled only for these alpha / beta versions as it would contain too much changeset for release versions, IMHO. |
The experiment addon could live on the |
Ohh, there is Bug 1366827 which could help us for Beta and Release Firefoxes 👍 :
@whimboo, would you mind to dig out how this bug could help us? |
Sorry but I don't have the time for doing that at the moment. Lets focus on the Nightly and experiment extension first. |
Sorry for the silence. I'm going to work on the 4.1 release in this Q1. I've just heard some good news: Changes coming to WebExtension API Experiments. A separated package will no longer be required, so it's a great change for us. |
Frankly this was the only feature that I used, so NTT became useless without this. I got tired of waiting, so I did https://github.com/Loirooriol/firefox-pushlog |
@Loirooriol the Nightly Tester Tools are an open source project and you could have contributed to it instead of creating a new extension. With the code in place we might have found a solution to ship it. |
With the rewrite of the extension we lost this feature. We have to add it back once the WebExtension API allows us to retrieve the changeset id.
The text was updated successfully, but these errors were encountered: