Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back pushlog feature #248

Open
whimboo opened this issue Sep 13, 2017 · 16 comments
Open

Add back pushlog feature #248

whimboo opened this issue Sep 13, 2017 · 16 comments
Milestone

Comments

@whimboo
Copy link
Contributor

whimboo commented Sep 13, 2017

With the rewrite of the extension we lost this feature. We have to add it back once the WebExtension API allows us to retrieve the changeset id.

@kyoshino kyoshino self-assigned this Sep 13, 2017
@kyoshino
Copy link
Contributor

My initial attempt is here, as mentioned in #235 (comment):
https://github.com/kyoshino/nightlyttr/compare/experiment

@kyoshino kyoshino modified the milestone: 4.1 Sep 13, 2017
@whimboo
Copy link
Contributor Author

whimboo commented Sep 14, 2017

Does it mean that users have to install the experiment addon separately, or how does it work?

@xabolcs
Copy link
Collaborator

xabolcs commented Sep 14, 2017

Pushlog is only relevant for short pushlogs.

Experiments run only on Nightly and Developer Edition.
Nightly has daily build, Developer Edition has weekly build.

@kyoshino
Copy link
Contributor

There are no WebExtensions APIs to retrieve the changeset, crash the app, and achieve other unimplemented features, so I think we need a separate experiment extension anyway. AFAIK the regular extension and experiment cannot be combined.

@whimboo
Copy link
Contributor Author

whimboo commented Sep 14, 2017

Maybe it's faster to request the addition of the changeset id to getBrowserInfo and getPlatformInfo.

@whimboo
Copy link
Contributor Author

whimboo commented Sep 14, 2017

The request could be added as dependency for bug 1215059. Maybe we can even request more data as we need for the customize titlebar feature.

@xabolcs
Copy link
Collaborator

xabolcs commented Sep 21, 2017

Maybe we can even request more data as we need for the customize titlebar feature.

Sure the prefix stuff is very limiting.

@whimboo
Copy link
Contributor Author

whimboo commented Sep 22, 2017

Which prefix stuff do you mean? For the title bar? This is not something I'm referring here for the pushlog feature.

@xabolcs
Copy link
Collaborator

xabolcs commented Sep 22, 2017

Yes, I meant the titlePreface stuff in browser.windows.update. But as You say, it's offtopic here.

@xabolcs
Copy link
Collaborator

xabolcs commented Oct 11, 2017

I vote for implementing the Nightly Tester Tools experiment addon!

It should contain all the missing features (not just this one), which we could file as bugs later. Once they got fixed, the features going to move to the base addon.

It will be available for the "blueish" Firefox (Nightly / Developer Edition) users (which should be our first class citizen IMHO).

This pushlog feature should be enabled only for these alpha / beta versions as it would contain too much changeset for release versions, IMHO.

@xabolcs
Copy link
Collaborator

xabolcs commented Oct 11, 2017

The experiment addon could live on the experiment branch, as @kyoshino already did use it.

@xabolcs
Copy link
Collaborator

xabolcs commented Oct 11, 2017

It will be available for the "blueish" Firefox (Nightly / Developer Edition) users (which should be our first class citizen IMHO).

Ohh, there is Bug 1366827 which could help us for Beta and Release Firefoxes 👍 :

The main Test Pilot extension and individual Test Pilot experiments are in the process of moving away from the Add-on SDK. The goal is to use webextension experiments, but of course they'll need those to be usable on release.

If we land this change in 55, then AMO-signed experiments could theoretically run on release in 55 and 56 but only admins can sign experiments with the AMO CA. Beginning in 57, only experiments signed with "Mozilla Extensions" will be installable.

@whimboo, would you mind to dig out how this bug could help us?

@whimboo
Copy link
Contributor Author

whimboo commented Oct 11, 2017

Sorry but I don't have the time for doing that at the moment. Lets focus on the Nightly and experiment extension first.

@kyoshino
Copy link
Contributor

kyoshino commented Jan 13, 2018

Sorry for the silence. I'm going to work on the 4.1 release in this Q1. I've just heard some good news: Changes coming to WebExtension API Experiments. A separated package will no longer be required, so it's a great change for us.

@Loirooriol
Copy link

Frankly this was the only feature that I used, so NTT became useless without this.

I got tired of waiting, so I did https://github.com/Loirooriol/firefox-pushlog

@whimboo
Copy link
Contributor Author

whimboo commented Jul 24, 2018

@Loirooriol the Nightly Tester Tools are an open source project and you could have contributed to it instead of creating a new extension. With the code in place we might have found a solution to ship it.

@kyoshino kyoshino removed their assignment Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants