Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: expression single quote vs double quotes #63

Closed
jamesbraza opened this issue Nov 16, 2023 · 1 comment
Closed

Request: expression single quote vs double quotes #63

jamesbraza opened this issue Nov 16, 2023 · 1 comment

Comments

@jamesbraza
Copy link

https://docs.github.com/en/actions/learn-github-actions/expressions#literals talks about how double quotes aren't valid inside GitHub expressions:

env:
    A1: ${{ "invalid" }}
    A2: ${{ 'valid' }}

I don't think action-validator v0.5.3 is catching this. I would like to request adding validation for that to this tool

@mpalmer
Copy link
Owner

mpalmer commented Nov 16, 2023

There's no validation of expressions at all at present, and while it would be a nice-to-have, I don't have any concrete plans of doing this work myself in the foreseeable future. I think that this particular request is covered by #22, so I'll close this off in favour of that issue.

@mpalmer mpalmer closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants