Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TIC and basepeak up to 105 minutes #93

Open
KarinSchork opened this issue Sep 25, 2024 · 4 comments
Open

remove TIC and basepeak up to 105 minutes #93

KarinSchork opened this issue Sep 25, 2024 · 4 comments

Comments

@KarinSchork
Copy link
Member

according to @SvitiMPC the values "up tp 105 minutes" can be dropped (doesnt fit all gradients anymore)

@julianu
Copy link
Member

julianu commented Sep 25, 2024

Is it that the time (105 mins) does not fit, or that you don't need this value anymore?
Basically, it represented the highest TIC/basepeak up to the final huge increase in the gradient. Or do you not mean the max but the real TIC up to there?

@KarinSchork
Copy link
Member Author

I think the problem is that it does only fit to a very specific gradient and is not really needed anymore. So we could drop the columns . @SvitiMPC please correct me if I got it wrong.

@julianu
Copy link
Member

julianu commented Sep 25, 2024

The actual time definitely needs to be specified by the user, so if this is needed link to #74

@SvitiMPC
Copy link

Karin is right. The gradient length was changed for our ISA. Moreover for Tims we have very short gradient. So this parameter is not up to date anymore. We do not use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants