Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] ThemeToggle not changing on press #302

Open
Dave-Wagner opened this issue Jan 8, 2025 · 7 comments
Open

[ BUG ] ThemeToggle not changing on press #302

Dave-Wagner opened this issue Jan 8, 2025 · 7 comments
Labels
bug Something isn't working

Comments

@Dave-Wagner
Copy link

Describe the bug
Using an unmodified (other than running through a tunnel and removing --ios from the Dev script) base starter, the ThemeToggle at the top right does absolutely nothing. If I had to guess it is only paying attention to the system default, in my case dark mode.

To Reproduce
Steps to reproduce the behavior:

  1. Run the init from the CLI and create a new Starter Base
  2. Run with 'bun dev' and open in Expo Go
  3. Click on 'MoonStar Icon'
  4. Theme does not toggle
  5. Note: It does work on the web version

Expected behavior
I expect the theme to switch between light and dark mode on press

Platform (please complete the following information):

  • Type: Device
  • OS: Android (Expo Go)

Additional context
Repo: https://github.com/Dave-Wagner/ebike-adventures

@Dave-Wagner Dave-Wagner added the bug Something isn't working label Jan 8, 2025
@TanushN
Copy link

TanushN commented Jan 13, 2025

Im having the same issue.

Same issue that was closed two weeks ago: #277

@mrzachnugent
Copy link
Owner

Do you have "userInterfaceStyle": "automatic" in your app.json?

Otherwise, can you please provide a minimal reproduction repo?

@Dave-Wagner
Copy link
Author

Dave-Wagner commented Jan 13, 2025

Yes, as you can see from the minimal reproduction repo I linked to in the original post.

edit: Oops, I hadn't heard a reply for a while so I went ahead and started a new repo with the same name, not using this library. Let me set up a new one following the directions and get back to you.

edit2: https://github.com/Dave-Wagner/starter-base

@mrzachnugent
Copy link
Owner

Unfortunately, I am unable to reproduce the error from https://github.com/Dave-Wagner/starter-base

Screen.Recording.2025-01-13.at.9.40.04.AM.mov

@Dave-Wagner
Copy link
Author

Dave-Wagner commented Jan 13, 2025

I should point out that I am specifically using Expo Go, not the Android emulator, however, even create an EAS build using an APK I have the same problem on device. I am using a Google Pixel 9.

Edit: I just ran it on the Emulator in Windows and it works as expected. Perhaps it has to do with the version of Android on my Pixel 9.

@Dave-Wagner
Copy link
Author

Why complete this issue? It's clearly not resolved. There is clearly an issue,. It should be addressed.

@TanushN
Copy link

TanushN commented Jan 17, 2025

Unfortunately, I am unable to reproduce the error from https://github.com/Dave-Wagner/starter-base

Screen.Recording.2025-01-13.at.9.40.04.AM.mov

Would you be able to try it on an actual device? I'm wondering if it's only a bug there.

For reference, I have a samsung s23 and have the same issue using Expo Go or the full on development apk. The theme only changes when I change my phone's light/dark mode settings.

@mrzachnugent mrzachnugent reopened this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants