Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove settings file from Cherish - look for a pattern to use settings from within the application #125

Open
jeffshaver opened this issue Jul 9, 2015 · 1 comment
Open

Remove settings file from Cherish - look for a pattern to use settings from within the application #125

jeffshaver opened this issue Jul 9, 2015 · 1 comment
Assignees
@trustieee
Labels
needs team discussion

Comments

@jeffshaver
Copy link
Contributor

Needs to be secure, but accessible from both client/server. Stuff like Initiative limit should be there, whether to run in debug or production mode (for mocking data).

We should only be using settings.json for service credential stuff, like Facebook App Id, secrets, AWS, etc.
@jeffshaver jeffshaver added ready and removed sprint labels Jul 9, 2015
@jeffshaver
Copy link
Contributor Author

How is Meteor.settings not secure? The only thing that is exposed to the client is anything inside the public key. Everything else is only available on the server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trustieee trustieee

Labels
needs team discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trustieee @jeffshaver