Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 3D Voronoi tessellation #16

Open
ilateur opened this issue Sep 25, 2024 · 4 comments
Open

Implement 3D Voronoi tessellation #16

ilateur opened this issue Sep 25, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ilateur
Copy link
Collaborator

ilateur commented Sep 25, 2024

No description provided.

@ilateur ilateur added the enhancement New feature or request label Sep 25, 2024
@ilateur
Copy link
Collaborator Author

ilateur commented Sep 25, 2024

I was thinking that the VoronoiTessellator gets a grid, so it already knows how many z-layers there are. Should it automatically decide to generate 3D grains if grid.size.z > 1? Or should the user specifically request 3D-ness themselves, in case they want to use only a few layers to still simulate a 2D structure? Or should it automatically detect 3D, unless the user specifies 2D? Or something else?

@lamoreel
Copy link
Contributor

I think it's most clean and user-friendly to let VoronoiTessellator detect if the grid is 3D or not and go with that, unless specified.

@ilateur
Copy link
Collaborator Author

ilateur commented Sep 25, 2024

And it should be the same class, right? Not a different thing, like in MuMax3?

@lamoreel
Copy link
Contributor

lamoreel commented Sep 25, 2024

Yes, I would embrace the OOP-character of Mumax+ and keep the same class, recycling as much functions, structs, members... as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants